Fix test_server spec helper to not leak fiber#7612
Draft
straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
Draft
Fix test_server spec helper to not leak fiber#7612straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
straight-shoota wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
Member
|
Mac OSX Mojave. I just ran it locally: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #7197
Refactors
test_serverspec helper to avoid leaking a fiber.As described in #7197 (comment) load testing this change introduces
Connection reset by peererrors on MacOS (@asterite Which version exactly did you test it on?). That's why this was extracted from the previous PR in order to merge the other features while this needs more investigation.I can't debug on MacOS, so I'd be happy to get some help here.