Skip to content

Add command and args to execvp error message #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Mar 12, 2019
Merged

Add command and args to execvp error message #7511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/std/process_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ describe Process do

it "raises if command could not be executed" do
# FIXME: Oddly doubled error message
expect_raises_errno(Errno::ENOENT, "execvp: No such file or directory: No such file or directory") do
Process.new("foobarbaz")
expect_raises_errno(Errno::ENOENT, %(execvp (foobarbaz "foo"): No such file or directory: No such file or directory)) do
Copy link
Contributor

@yxhuvud yxhuvud Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the printed command need a length restriction? If it has many arguments, then there could be some issues with the usability.

Copy link
Member Author

@straight-shoota straight-shoota Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restricting the length could also have usability implications. The best solution would be to change the order and print the failed command after the libc error message. Errno doesn't support that though.

Process.new("foobarbaz", ["foo"])
end
end

Expand Down
12 changes: 11 additions & 1 deletion src/process.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,17 @@ class Process
argv << Pointer(UInt8).null

LibC.execvp(command, argv)
raise Errno.new("execvp")

error_message = String.build do |io|
io << "execvp ("
command.inspect_unquoted(io)
args.try &.each do |arg|
io << ' '
arg.inspect(io)
end
io << ")"
end
raise Errno.new(error_message)
end

private def self.reopen_io(src_io : IO::FileDescriptor, dst_io : IO::FileDescriptor)
Expand Down