Detect nesting it and pending at run-time

[makenowjust]

Fix #7192
Close #7207

[sdogruyol]

Thank you @makenowjust 👍

[asterite]

Looks good! I just left a question.

[asterite]

What is this for?

[makenowjust]

See full code:

    def expect_raises(klass : T.class, message = nil, file = __FILE__, line = __LINE__) forall T
      yield
    rescue ex : T
      # We usually bubble Spec::AssertaionFailed, unless this is the expected exception
      if ex.is_a?(Spec::AssertionFailed) && klass != Spec::AssertionFailed
        raise ex
      end

      # `NestingSpecError` is treated as the same above.
      if ex.is_a?(Spec::NestingSpecError) && klass != Spec::NestingSpecError
        raise ex
      end

      # ...
    end

Please tell me more correct sentence which means this if you know.

[straight-shoota]

Just asking: Is this really worth the added complexity?

[makenowjust]

Please don't merge this for now because this doesn't fix #7192 entirely. Sorry 🙇 I'll fix it asap.
Fixed!!

@straight-shoota At least we have an issue #7192 and this is the simplest way to fix it.

[makenowjust]

Now, nesting pending/it doesn't break crystal spec -v output. I think it means #7192 is fixed.

Example:

require "spec"

it "foo" do
  it "bar" do
  end
end

it "baz" do
  pending
end

Old (broken) output:

New (fixed) output:

[Fryguy]

If we were to ever get to parallel test execution, would this class variable cause a problem?

[asterite]

Yes

[asterite]

Oh, actually, I was replying generically that class variables are to be used carefully in a parallel context. Not sure about this case, though