Skip to content

Allow different values than only -1, 0 and 1 to be returned by <=>#7277

Merged
straight-shoota merged 7 commits intomasterfrom
unknown repository
Mar 6, 2019
Merged

Allow different values than only -1, 0 and 1 to be returned by <=>#7277
straight-shoota merged 7 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 5, 2019

Closes #7276

This changes the spaceship's documentation to allow more values than only -1, 0 and 1 to be returned.

# Implements the comparison operator.
# The comparison operator.
#
# See also: `Object#<=>`.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because Object#<=> no longer exists.

Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to use the scheme returns -1, 0, 1 (or neg, zero, pos) depending on ... everywhere in the documentation. If you want to change that...

But I'll approve either way.

@straight-shoota straight-shoota added this to the 0.28.0 milestone Feb 11, 2019
@straight-shoota straight-shoota merged commit a43fb94 into crystal-lang:master Mar 6, 2019
@straight-shoota
Copy link
Member

Thank you @r00ster91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants