Merged
Conversation
If the last value was 1 << 31 an overflow would be thrown. This is not changing the current behavior. The Enum flags with UInt64 base type work only if the values are explicit.
Otherwise OverflowError and raise method will need to be defined
asterite
approved these changes
Jan 4, 2019
RX14
requested changes
Jan 4, 2019
| end | ||
| else | ||
| counter + 1 | ||
| counter &+ 1 |
Member
There was a problem hiding this comment.
An issue to fix or discuss this behaviour should be created.
Member
Author
There was a problem hiding this comment.
Done at #7268. Is there any other feedback of the changes of the PR?
RX14
approved these changes
Jan 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR updates the stdlib to use unchecked operations & conversions where needed.
It's easier to review per commit than per changes.
compiler_specs need to use
&+rather than+or including prelude would be required.The
to_X!operations are used when calling libs instead ofto_X.