-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add unsafe number ops #7226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bcardiff
merged 7 commits into
crystal-lang:master
from
bcardiff:feature/unsafe-number-ops
Jan 3, 2019
Merged
Add unsafe number ops #7226
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
81b038e
Add convert as primitive to be used on #to_* methods
bcardiff 4ae8cc9
Add Int#to_*! methods
bcardiff 051a6d3
Add Int.new! Float.new! variants
bcardiff 7136750
Add Int#&**. Refactor Int#** due to possible unwanted overflow.
bcardiff 7f87fa2
Add Enum#to_*! methods
bcardiff aedbdaf
Add BigInt#to_*! methods
bcardiff 1edf4a8
Refactor: BigInt range check
bcardiff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| require "../../spec_helper" | ||
|
|
||
| describe "Code gen: convert primitives" do | ||
| describe "to_*!" do | ||
| it "works from negative values to unsigned types" do | ||
| run(%( | ||
| -1.to_u! == 4294967295_u32 | ||
| )).to_b.should be_true | ||
| end | ||
|
|
||
| it "works from greater values to smaller types" do | ||
| run(%( | ||
| 47866.to_i8! == -6_i8 | ||
| )).to_b.should be_true | ||
| end | ||
|
|
||
| it "preserves negative sign" do | ||
| run(%( | ||
| -1_i8.to_i! == -1_i32 | ||
| )).to_b.should be_true | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.