Skip to content

Release 0.27.0#6992

Merged
bcardiff merged 7 commits into
crystal-lang:masterfrom
bcardiff:changelog/0.27.0
Nov 1, 2018
Merged

Release 0.27.0#6992
bcardiff merged 7 commits into
crystal-lang:masterfrom
bcardiff:changelog/0.27.0

Conversation

@bcardiff
Copy link
Copy Markdown
Member

@bcardiff bcardiff added this to the 0.27.0 milestone Oct 25, 2018
Comment thread CHANGELOG.md
@straight-shoota
Copy link
Copy Markdown
Member

Missing: #6485 also added File#delete, Dir#tempdir and API docs for File

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@RX14
Copy link
Copy Markdown
Member

RX14 commented Oct 27, 2018

If we're doing to enable overflow checking by default in 0.28.0, it would be nice to have a compile-time flag to enable overflow checking in 0.27.0 so that packages can be tested properly and move to the new operators beforehand.

@bcardiff
Copy link
Copy Markdown
Member Author

The stdlib can’t use &+ until 0.27 is released. We would need to add a bunch of version checks like the one in checked/unchecked scope.

I understand it would be good to have a compiler flag to let libraries test before the behavior is changed, but that only can happen after 0.27.0. Unless the stdlib is plagued with lots of checks. I would prefer to avoid that. But we can schedule 0.27.1 for that maybe.

@RX14
Copy link
Copy Markdown
Member

RX14 commented Oct 28, 2018

@bcardiff yeah, 0.27.1 sounds good for that.

Comment thread CHANGELOG.md
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@bcardiff
Copy link
Copy Markdown
Member Author

bcardiff commented Nov 1, 2018

Thanks everybody for the feedback.

@bcardiff bcardiff merged commit c9d1eef into crystal-lang:master Nov 1, 2018
@RX14
Copy link
Copy Markdown
Member

RX14 commented Nov 2, 2018

I never got a time to read the changelog before merge :(

I hate the way the breaking changes aren't all at the beginning

@bcardiff
Copy link
Copy Markdown
Member Author

bcardiff commented Nov 2, 2018

@RX14 the structure has been the same for a couple of releases. We can keep changing it of course but I was not aware of a proposal. Regarding this PR, the gross of the content has been there since a week ago, and for a Release PR it's a reasonable time window.

@straight-shoota
Copy link
Copy Markdown
Member

Maybe some kind of last call notice?

@RX14
Copy link
Copy Markdown
Member

RX14 commented Nov 2, 2018

@bcardiff sorry about that - I didn't realise it has been a week. I guess I'm busier than I thought...

The current release note format is better than before.

@bcardiff bcardiff deleted the changelog/0.27.0 branch November 5, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants