Skip to content

Fix Socket#reuse_port? if SO_REUSEPORT is not supported #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RX14 merged 2 commits into from
Sep 12, 2018
Merged

Fix Socket#reuse_port? if SO_REUSEPORT is not supported #6706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ed8b9
Fix Socket#reuse_port? if SO_REUSEPORT is not supported
straight-shoota Aug 9, 2018
9c8e332
fixup! Fix Socket#reuse_port? if SO_REUSEPORT is not supported
straight-shoota Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/socket.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,15 @@ class Socket < IO
end

def reuse_port?
getsockopt_bool LibC::SO_REUSEPORT
ret = getsockopt(LibC::SO_REUSEPORT, 0) do |errno|
# If SO_REUSEPORT is not supported, the return value should be `false`
Copy link
Copy Markdown
Collaborator

@ysbaddaden ysbaddaden Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for the comment: code is explicit enough.

if errno.errno == Errno::ENOPROTOOPT
return false
else
raise errno
end
end
ret != 0
end

def reuse_port=(val : Bool)
Expand Down Expand Up @@ -445,9 +453,13 @@ class Socket < IO

# Returns the modified *optval*.
def getsockopt(optname, optval, level = LibC::SOL_SOCKET)
getsockopt(optname, optval, level) { |errno| raise errno }
end

protected def getsockopt(optname, optval, level = LibC::SOL_SOCKET)
optsize = LibC::SocklenT.new(sizeof(typeof(optval)))
ret = LibC.getsockopt(fd, level, optname, (pointerof(optval).as(Void*)), pointerof(optsize))
raise Errno.new("getsockopt") if ret == -1
yield Errno.new("getsockopt") if ret == -1
optval
end

Expand Down