Add examples to Socket::Server#accept API docs#6705
Merged
RX14 merged 2 commits intocrystal-lang:masterfrom Sep 12, 2018
Merged
Add examples to Socket::Server#accept API docs#6705RX14 merged 2 commits intocrystal-lang:masterfrom
RX14 merged 2 commits intocrystal-lang:masterfrom
Conversation
asterite
requested changes
Sep 11, 2018
src/socket/server.cr
Outdated
| # require "socket" | ||
| # | ||
| # server = TCPServer.new(2202) | ||
| # while socket = server.accept |
src/socket/server.cr
Outdated
| # require "socket" | ||
| # | ||
| # server = TCPServer.new(2202) | ||
| # while socket = server.accept |
Member
There was a problem hiding this comment.
But server.accept is always truthy...
jhass
reviewed
Sep 12, 2018
| # require "socket" | ||
| # | ||
| # server = TCPServer.new(2202) | ||
| # while true |
Member
There was a problem hiding this comment.
Both are fine. I'm fact, I'm starting to think we should remove loop, it adds absolutely nothing and it's just another way of doing something.
Member
There was a problem hiding this comment.
well I guess it was useful when it had its block argument :P
asterite
approved these changes
Sep 12, 2018
RX14
approved these changes
Sep 12, 2018
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
* Add examples to Socket::Server#accept * fixup! Add examples to Socket::Server#accept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.