Skip to content

Remove deprecated alias HTTP::Server#bind_ssl #6699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RX14 merged 1 commit into from
Sep 11, 2018
Merged

Remove deprecated alias HTTP::Server#bind_ssl #6699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions spec/std/http/server/server_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,30 +422,6 @@ module HTTP
end
end

describe "#bind_ssl" do
it "binds SSL server context" do
server = Server.new do |context|
context.response.puts "Test Server (#{context.request.headers["Host"]?})"
context.response.close
end

server_context, client_context = ssl_context_pair

socket = OpenSSL::SSL::Server.new(TCPServer.new("127.0.0.1", 0), server_context)
server.bind socket
ip_address1 = server.bind_ssl "127.0.0.1", 0, server_context
ip_address2 = socket.local_address

spawn server.listen
Fiber.yield

HTTP::Client.get("https://#{ip_address1}", tls: client_context).body.should eq "Test Server (#{ip_address1})\n"
HTTP::Client.get("https://#{ip_address2}", tls: client_context).body.should eq "Test Server (#{ip_address2})\n"

server.close
end
end

describe "#listen" do
it "fails after listen" do
server = Server.new { }
Expand Down
6 changes: 0 additions & 6 deletions src/http/server.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,12 +258,6 @@ class HTTP::Server
def bind_tls(address : Socket::IPAddress, context : OpenSSL::SSL::Context::Server) : Socket::IPAddress
bind_tls(address.address, address.port, context)
end

# DEPRECATED: Use `#bind_tls`.
# TODO: remove in 0.27.0
def bind_ssl(*args)
bind_tls(*args)
end
{% end %}

# Parses a socket configuration from *uri* and adds it to this server.
Expand Down