Skip to content

Enable HTTP::Server#close in websocket specs #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
straight-shoota wants to merge 1 commit into from
Closed

Enable HTTP::Server#close in websocket specs #6671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/std/http/web_socket_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ describe HTTP::WebSocket do
HTTP::WebSocket::Protocol.new(address.address, port: address.port, path: "/")
end
ensure
# http_server.try &.close # TODO: Uncomment when #5958 is fixed
http_server.try &.close
end

describe "handshake fails if server does not verify Sec-WebSocket-Key" do
Expand All @@ -405,7 +405,7 @@ describe HTTP::WebSocket do
HTTP::WebSocket::Protocol.new(address.address, port: address.port, path: "/")
end
ensure
# http_server.try &.close # TODO: Uncomment when #5958 is fixed
http_server.try &.close
end

it "Sec-WebSocket-Accept incorrect" do
Expand All @@ -424,7 +424,7 @@ describe HTTP::WebSocket do
HTTP::WebSocket::Protocol.new(address.address, port: address.port, path: "/")
end
ensure
# http_server.try &.close # TODO: Uncomment when #5958 is fixed
http_server.try &.close
end
end

Expand Down