Add tls scheme to HTTP::Server#bind and rename HTTP::Server#bind_ssl#6533
Merged
RX14 merged 2 commits intocrystal-lang:masterfrom Aug 13, 2018
Merged
Conversation
straight-shoota
force-pushed
the
jm/feature/http-server-bind-tls
branch
from
a0e4bd3 to
8182fe2
Compare
straight-shoota
force-pushed
the
jm/feature/http-server-bind-tls
branch
from
8182fe2 to
daaed8b
Compare
jhass
approved these changes
Aug 13, 2018
RX14
added
the
breaking-change
RX14
approved these changes
Aug 13, 2018
Member
RX14
left a comment
RX14
left a comment
There was a problem hiding this comment.
Do we want to make such a minimal breaking change to an API just introduced?
Member
Yes, I think its fair. People using it should still be actively working on their projects. |
Member
Author
|
Yeah, it's too bad 0.26.0 is already done. Maybe something breaks and we need to ship 0.26.1 right away, then this could be included in the bug fix ;) |
Member
|
Kemal already update it's api to use bind_ssl. |
Member
Author
|
You mean to temporarily re-add |
Member
|
Yes. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
tls://scheme forHTTP::Server#bindand makes it default in documentation. It also renamesHTTP::Server#bind_ssltoHTTP::Server#bind_tls.Follow-up on #6500 (discussion starting at #6500 (comment))