Revert restrictict exp.@var to types in the same hierarchy#6484
Merged
bcardiff merged 3 commits intocrystal-lang:masterfrom Aug 6, 2018
Merged
Revert restrictict exp.@var to types in the same hierarchy#6484bcardiff merged 3 commits intocrystal-lang:masterfrom
exp.@var to types in the same hierarchy#6484bcardiff merged 3 commits intocrystal-lang:masterfrom
Conversation
Member
|
Why the Char & IO refactor are preserved? Checking against the instance variable is simpler. |
Member
Author
|
@asterite I just think it's easier to read |
ysbaddaden
approved these changes
Aug 5, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #6358 to avoid an unwanted breaking change in the next release but keeps two of the refactors introduced in that PR.