Enable Time::Location loader on win32#6363
Merged
RX14 merged 5 commits intocrystal-lang:masterfrom Aug 31, 2018
Merged
Conversation
With File support for win32, the POSIX implementations work on win32 as well.
straight-shoota
changed the title
RX14
approved these changes
Jul 11, 2018
Replace File.expand_path with File.join to work on win32
RX14
approved these changes
Jul 11, 2018
RX14
added
kind:feature
platform:windows
asterite
approved these changes
Aug 30, 2018
Member
asterite
left a comment
asterite
left a comment
There was a problem hiding this comment.
I didn't try this on Windows, but I trust @RX14 and @straight-shoota if they tested it.
ysbaddaden
approved these changes
Aug 31, 2018
Collaborator
ysbaddaden
left a comment
ysbaddaden
left a comment
There was a problem hiding this comment.
Looks good. Feel free to merge when ready (or is it?).
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
* Enable Time::Location loader on win32 With File support for win32, the POSIX implementations work on win32 as well. * Add missing with_zoneinfo in Time spec * Fix Time::Location.load_local with TZ and ZONEINFO * fixup! Enable Time::Location loader on win32 Replace File.expand_path with File.join to work on win32 * fixup! Add missing with_zoneinfo in Time spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #5623 merged, the location loader methods can finally use the
FileAPI on win32.I also fixed a few missing
with_zoneinfo.The spec withENV["TZ"] = ""doesn't work on win32 because empty string is identified asnil(see #6333 (comment)).