Skip to content

Remove :nodoc: from Time::Format#6214

Merged
bcardiff merged 2 commits into
crystal-lang:masterfrom
straight-shoota:jm/fix/6206
Jun 21, 2018
Merged

Remove :nodoc: from Time::Format#6214
bcardiff merged 2 commits into
crystal-lang:masterfrom
straight-shoota:jm/fix/6206

Conversation

@straight-shoota
Copy link
Copy Markdown
Member

Fixes #6206

@bcardiff bcardiff added this to the 0.25.1 milestone Jun 18, 2018
@bcardiff
Copy link
Copy Markdown
Member

@straight-shoota FYI, the ci complained about formatting issues.

Error: formatting './src/time/format/custom/yaml_date.cr' produced changes

@straight-shoota
Copy link
Copy Markdown
Member Author

That's weird. My local compiler ( 0.25.0+12 [8e5e4c7f6] (2018-06-18)) didn't complain on bin/crystal tool format src/time/format/custom/yaml_date.cr --check. But running it without --check, it still produced a change, removing an empty line:

--- a/src/time/format/custom/yaml_date.cr
+++ b/src/time/format/custom/yaml_date.cr
@@ -10,7 +10,6 @@ struct Time::Format
   # As an additional note, Ruby's Psych YAML parser also implements a
   # custom time parser, probably for this same reason.
   module YAML_DATE
-
     # Parses a string into a `Time`.
     def self.parse?(string) : Time?
       parser = Parser.new(string)

@bcardiff bcardiff merged commit 99be354 into crystal-lang:master Jun 21, 2018
@straight-shoota straight-shoota deleted the jm/fix/6206 branch June 21, 2018 08:25
@RX14 RX14 added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants