Skip to content

Add specs for Time parser to raise when time zone is missing#6174

Merged
bcardiff merged 2 commits into
crystal-lang:masterfrom
straight-shoota:jm/feature/time-format-emtpy-zone-spec
Jun 15, 2018
Merged

Add specs for Time parser to raise when time zone is missing#6174
bcardiff merged 2 commits into
crystal-lang:masterfrom
straight-shoota:jm/feature/time-format-emtpy-zone-spec

Conversation

@straight-shoota
Copy link
Copy Markdown
Member

Surpasses #5382

Comment thread src/time/format.cr Outdated
# * **%k**: hour of the day, 24-hour clock, blank padded (" 0", " 1", ..., "24")
# * **%l**: hour of the day, 12-hour clock, blank padded (" 0", " 1", ..., "12")
# * **%L**: milliseconds, zero padded (000, 001, ..., 999)
# * **%L**: milliseconds, zero padded (000, 001, ..., 999) (also **%3N**)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/also/same as/ ?

@straight-shoota straight-shoota force-pushed the jm/feature/time-format-emtpy-zone-spec branch from 8a5ef30 to a09c579 Compare June 11, 2018 13:45
@straight-shoota straight-shoota force-pushed the jm/feature/time-format-emtpy-zone-spec branch from a09c579 to dadc109 Compare June 11, 2018 18:55
@bcardiff bcardiff added this to the 0.25.1 milestone Jun 15, 2018
@bcardiff bcardiff merged commit 8e5e4c7 into crystal-lang:master Jun 15, 2018
@bcardiff
Copy link
Copy Markdown
Member

Thanks @straight-shoota

@straight-shoota straight-shoota deleted the jm/feature/time-format-emtpy-zone-spec branch June 15, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants