Add path to UNIXSocket created by UNIXServer#5869
Merged
RX14 merged 1 commit intocrystal-lang:masterfrom Apr 13, 2018
Merged
Conversation
sdogruyol
approved these changes
Apr 13, 2018
jhass
approved these changes
Apr 13, 2018
RX14
approved these changes
Apr 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
UNIXServercreates an instance ofUNIXSocketfor every incoming socket connection but unlike client sockets, the values forlocal_addressandremote_addresswere missing. This PR adds them.There were specs to explicitly check that
local_addressandremote_addresson a serverUNIXSocketwould be""but I don't think there is any reason for this and they should in fact return the path the server listens to.