Skip to content

Fix String#dump for UTF-8 charachters > \uFFFF #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RX14 merged 1 commit into from
Feb 2, 2018
+9 −4
Merged

Fix String#dump for UTF-8 charachters > \uFFFF #5668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions spec/std/string_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,15 +1452,17 @@ describe "String" do
"\t".dump.should eq("\"\\t\"")
"\v".dump.should eq("\"\\v\"")
"\#{".dump.should eq("\"\\\#{\"")
"á".dump.should eq("\"\\u00e1\"")
"á".dump.should eq("\"\\u00E1\"")
"\u{81}".dump.should eq("\"\\u0081\"")
"\u{1F48E}".dump.should eq %("\\u{1F48E}")
end

it "dumps unquoted" do
"a".dump_unquoted.should eq("a")
"\\".dump_unquoted.should eq("\\\\")
"á".dump_unquoted.should eq("\\u00e1")
"á".dump_unquoted.should eq("\\u00E1")
"\u{81}".dump_unquoted.should eq("\\u0081")
"\u{1F48E}".dump_unquoted.should eq "\\u{1F48E}"
end

it "inspects" do
Expand All @@ -1477,13 +1479,15 @@ describe "String" do
"\#{".inspect.should eq("\"\\\#{\"")
"á".inspect.should eq("\"á\"")
"\u{81}".inspect.should eq("\"\\u0081\"")
"\u{1F48E}".inspect.should eq %("\u{1F48E}")
end

it "inspects unquoted" do
"a".inspect_unquoted.should eq("a")
"\\".inspect_unquoted.should eq("\\\\")
"á".inspect_unquoted.should eq("á")
"\u{81}".inspect_unquoted.should eq("\\u0081")
"\u{1F48E}".inspect_unquoted.should eq "\u{1F48E}"
end

it "does *" do
Expand Down
5 changes: 3 additions & 2 deletions src/string.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3950,11 +3950,12 @@ class String

private def dump_unicode(char, io)
io << "\\u"
io << '{' if char.ord > 65535
io << "0" if char.ord < 4096
io << "0" if char.ord < 256
io << "0" if char.ord < 16
char.ord.to_s(16, io)
io << ""
char.ord.to_s(16, io, upcase: true)
io << '}' if char.ord > 65535
end

def starts_with?(str : String)
Expand Down