Move win32 stubs into a separate file#5484
Merged
Merged
Conversation
straight-shoota
approved these changes
Dec 30, 2017
asterite
approved these changes
Jan 2, 2018
Member
asterite
left a comment
asterite
left a comment
There was a problem hiding this comment.
Just small comments regarding skip_file vs skip_file()
|
|
||
| {% skip_file() %} | ||
| {% end %} | ||
| {% skip_file() if flag?(:win32) %} |
Member
There was a problem hiding this comment.
we can probably use skip_file here
Member
Author
There was a problem hiding this comment.
Yeah, I was waiting for #5493 to make this change all at once.
| def read_utf8(io, slice) | ||
| raise NotImplementedError.new("IO::Decoder#read_utf8") | ||
| end | ||
| {% skip_file() if flag?(:win32) %} |
RX14
added
kind:refactor
topic:stdlib
platform:windows
lukeasrodgers
pushed a commit
to lukeasrodgers/crystal
that referenced
this pull request
Jan 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A matter of taste, but I think it's cleaner this way - we can aim to eliminate the
windows_stubs.crfile once we have a fairly complete port.