Skip to content

Fix: return thread to pool after scheduler shutdown [fixup #15885] #16750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 4 commits into from
Mar 22, 2026
Merged

Fix: return thread to pool after scheduler shutdown [fixup #15885] #16750

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
871e7d2
Fix: return thread to pool after scheduler shutdown [fixup #15885]
ysbaddaden Mar 17, 2026
b8a397e
Group event loop unregistration and thread pool checking to main fibe…
ysbaddaden Mar 20, 2026
da1a718
Revert "Group event loop unregistration and thread pool checking to m…
ysbaddaden Mar 20, 2026
72a1d5a
move thread pool checkin to run_loop
ysbaddaden Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/fiber/execution_context/parallel/scheduler.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ module Fiber::ExecutionContext
end
ensure
@event_loop.unregister(self)
ExecutionContext.thread_pool.checkin
end

private def find_next_runnable : Fiber?
Expand Down
Loading