Move execution context event loop lock to each event loop#16520
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Dec 24, 2025
Merged
Conversation
straight-shoota
approved these changes
Dec 19, 2025
Member
straight-shoota
left a comment
There was a problem hiding this comment.
Placing the lock on the event loop looks good.
But I'm wondering if we should move the implementation to EventLoop#lock? since it's shared across most subclasses. It's trivial to override with a no-op for io_uring.
That would put an unused @lock ivar in EventLoop::IOUring though 🤷
So maybe this is just fine.
Collaborator
Author
|
There could be a |
7c147ed to
6ee0c43
Compare
Collaborator
Author
|
Fixed conflicts with the master branch and added |
straight-shoota
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a requirement for io_uring, and it improves readability despite a slight duplication.
Extracted from #16264