Allow sending Bytes via WebSocket#16216
Closed
carlhoerberg wants to merge 1 commit intocrystal-lang:masterfrom
Closed
Allow sending Bytes via WebSocket#16216carlhoerberg wants to merge 1 commit intocrystal-lang:masterfrom
carlhoerberg wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
Crystal 1.18.0 regression
Collaborator
|
I believe other methods that take a message are also affected, such as It also means we're missing specs for the bytes case. |
Member
|
We have a spec that tests sending |
Member
|
Actually, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crystal 1.18.0 regression