Refactor internal Crystal::System::Process#fork on UNIX#16191
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Oct 30, 2025
Merged
Conversation
The method now yields to let the caller do something in the child process after fork, rather than always compiling both paths (fork vs fork/exec) even though most applications only use the fork/exec path.
Member
|
I suppose this is fine as an intermediary. We're planning to stop using |
straight-shoota
approved these changes
Oct 28, 2025
Member
|
This change broke Process.fork # Error: 'Crystal::System::Process.fork' is expected to be invoked with a block, but no block was given
|
This was referenced Nov 15, 2025
straight-shoota
added a commit
that referenced
this pull request
Nov 18, 2025
Rename the internal method to `system_fork` so we clearly separate it from the method that the public API and the compiler use. Fixes #16191 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method now yields to let the caller do something in the child process after fork, rather than always compiling both paths (fork vs fork/exec) even though most applications only use the fork/exec path.
Extracted from #16174.