Fix return type of system_close_on_exec= on Windows#16095
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 17, 2025
Merged
Fix return type of system_close_on_exec= on Windows#16095straight-shoota merged 1 commit intocrystal-lang:masterfrom
system_close_on_exec= on Windows#16095straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
straight-shoota
changed the title
system_close_on_exec= on Windows [fixup #15698]system_close_on_exec= on Windows
Blacksmoke16
approved these changes
Aug 17, 2025
nobodywasishere
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#system_close_on_exec=(and thus#close_on_exec=) returnsNilon Windows. But #15698 added a type-restriction toBool. We didn't notice this discrepancy before, because this method was never called on Windows until we enabled the specs for that in #14716.Changing the return value to
falseon Windows should be the correct behaviour. If the parameter istrue, the method raises.This is a classic integration issue. It could've been avoided by testing each change against current master directly before merging it. But luckily they are pretty rare, so there's no urgent need to do something about it.