Use proper ANSI reset codes in Colorize#16052
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Sep 28, 2025
Merged
Use proper ANSI reset codes in Colorize#16052straight-shoota merged 4 commits intocrystal-lang:masterfrom
Colorize#16052straight-shoota merged 4 commits intocrystal-lang:masterfrom
Conversation
Blacksmoke16
commented
Aug 3, 2025
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
I'm a bit wary about modifying Colorize while we haven't figured out how to make it thread-safe (#15995). But this seems to be a very straightforward extension of the existing code, so this is probably fine.
straight-shoota
approved these changes
Aug 3, 2025
straight-shoota
approved these changes
Sep 26, 2025
straight-shoota
changed the title
Colorize
Contributor
|
Thanks a lot for fix this issue, I meet a issue cause by this before. |
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/ansi-sequences-modified-unexpectedly/8722/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially handles #10652. The example in the OP now works as expected, but does NOT solve #10652 (comment); which would require a more substantial refactor.