Move method doc comments to inside {% begin %} [fixup #16034]#16047
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Aug 4, 2025
Merged
Move method doc comments to inside {% begin %} [fixup #16034]#16047straight-shoota merged 1 commit intocrystal-lang:masterfrom
{% begin %} [fixup #16034]#16047straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
Blacksmoke16
added
the
kind:bug
straight-shoota
approved these changes
Aug 2, 2025
straight-shoota
changed the title
{% begin %}{% begin %} [fixup #16034]
straight-shoota
added
kind:docs
topic:stdlib:files
and removed
kind:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that after #16034, none of the methods that had the deprecated parameter had docs anymore. I think the gist of it is
{% begin %}leaves an empty line so the docs aren't actually applied to the method.