Support Proc.new(Void*, Void*) in the interpreter#16044
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Aug 4, 2025
Merged
Support Proc.new(Void*, Void*) in the interpreter#16044straight-shoota merged 5 commits intocrystal-lang:masterfrom
Proc.new(Void*, Void*) in the interpreter#16044straight-shoota merged 5 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #12495.
This constructor is now a primitive in interpreted code, and accepts both
CompiledDefpointers and C function pointers, assuming the latter by default, unless a previousProcLiteralhas created the pointer. The interpreter will then compile a wrapper on the fly; eventually theexternal_var_getprimitive from the original issue may adopt a similar technique.Two
Procs with the same C function pointer will refer to the sameCompiledDef. EachCompiledDefmore or less maintains its ownFFI::CallInterface; there is no FFI closure involved, unlike Crystal procs.This enables networking on Windows inside the interpreter, and also drops a workaround in the IOCP event loop.