Avoid deprecation warnings in File and TCPSocket constructors [fixup #16034]#16043
Merged
Blacksmoke16 merged 2 commits intocrystal-lang:masterfrom Aug 1, 2025
Merged
Avoid deprecation warnings in File and TCPSocket constructors [fixup #16034]#16043Blacksmoke16 merged 2 commits intocrystal-lang:masterfrom
File and TCPSocket constructors [fixup #16034]#16043Blacksmoke16 merged 2 commits intocrystal-lang:masterfrom
Conversation
Blacksmoke16
approved these changes
Aug 1, 2025
Member
Blacksmoke16
left a comment
There was a problem hiding this comment.
Confirmed no longer getting deprecation warnings from the stdlib.
Member
|
Seems there's one more: In D:\a\_temp\crystal-nightly-true-undefined\src\crystal\system\win32\file_descriptor.cr:369:59
369 | io = IO::FileDescriptor.new(handle.address, blocking: true)
^
Warning: Warning: Deprecated argument blocking. Use IO::FileDescriptor.set_blocking instead.EDIT: What is |
Member
|
|
Collaborator
Author
|
@Blacksmoke16 It looks like you have a mismatch compiler vs And master is fine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use internal constructors to pass the deprecated
blockingargument so we don't warn about stdlib internal calls inFileandTCPSocket.Ref. #16034 (comment)