Fix: Copy annotations in Crystal::Def#expand_default_arguments#16007
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jul 22, 2025
Conversation
straight-shoota
changed the title
Crystal::Def#expand_default_arguments doesn't copy arg annotationsCrystal::Def#expand_default_arguments
straight-shoota
added
the
kind:bug
straight-shoota
approved these changes
Jul 21, 2025
mverzilli
reviewed
Jul 21, 2025
mverzilli
left a comment
mverzilli
left a comment
There was a problem hiding this comment.
~200 lines, one function 😮💨 . Looks good, but don't we need a couple of new specs for this?
Member
|
Except for the actual setter calls, this is just a refactor and the code should be covered by existing specs. We could add individual spec cases that ensure annotations are duplicated, but that feels a bit too detailed. We'll have that covered by feature specs for deprecated parameters in #15999 |
straight-shoota
changed the title
Crystal::Def#expand_default_argumentsCrystal::Def#expand_default_arguments
mverzilli
approved these changes
Jul 21, 2025
This was referenced Jul 21, 2025
ysbaddaden
deleted the
fix/crystal-def-expand-default-arguments-doesnt-copy-annotations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this should be considered a bug, we just never had any use from annotations on expanded def args before.
Extracted from #15999.