Add Time::Location#{to,from}_{json,yaml}#15939
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jul 2, 2025
Merged
Add Time::Location#{to,from}_{json,yaml}#15939straight-shoota merged 2 commits intocrystal-lang:masterfrom
Time::Location#{to,from}_{json,yaml}#15939straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
Member
|
We should add specs for these methods as well. |
Contributor
Author
|
Sure, where should I add 'em? |
Member
|
I believe |
Sija
force-pushed
the
serialize-time-location
branch
2 times, most recently
from
cdf0abe to
74440ef
Compare
Sija
force-pushed
the
serialize-time-location
branch
from
74440ef to
ba7b99d
Compare
straight-shoota
approved these changes
Jun 30, 2025
Contributor
Author
|
Is it possible to get this into 1.17 release? |
ysbaddaden
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems useful to have in stdlib.