Fix: XML::TextReader must keep IO object reference [fixup #15906]#15933
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jun 30, 2025
Merged
Conversation
ysbaddaden
added
kind:bug
straight-shoota
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the std xml specs could sometimes lead to a segfault. The problem is that the IO object passed to XML::TextReader can be collected by the GC before the XML::TextReader is finalized, leading to a segfault when libxml trying to close the input buffer, hence close the IO object, and 💥
Also harmonizes the callbacks to use
->methodwith the rest of the libxml library.fixup #15899
fixup #15906