Skip to content

Fix: set IO::Stapled.pipe blocking args to nil, as per IO.pipe #15925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Jun 27, 2025
Merged

Fix: set IO::Stapled.pipe blocking args to nil, as per IO.pipe #15925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/io/stapled.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class IO::Stapled < IO
#
# Both endpoints and the underlying `IO`s are closed after the block
# (even if `sync_close?` is `false`).
def self.pipe(read_blocking : Bool = false, write_blocking : Bool = false, &)
def self.pipe(read_blocking : Bool? = nil, write_blocking : Bool? = nil, &)
IO.pipe(read_blocking, write_blocking) do |a_read, a_write|
IO.pipe(read_blocking, write_blocking) do |b_read, b_write|
a, b = new(a_read, b_write, true), new(b_read, a_write, true)
Expand All @@ -123,7 +123,7 @@ class IO::Stapled < IO

# Creates a pair of bidirectional pipe endpoints connected with each other
# and returns them in a `Tuple`.
def self.pipe(read_blocking : Bool = false, write_blocking : Bool = false) : {self, self}
def self.pipe(read_blocking : Bool? = nil, write_blocking : Bool? = nil) : {self, self}
a_read, a_write = IO.pipe(read_blocking, write_blocking)
b_read, b_write = IO.pipe(read_blocking, write_blocking)
return new(a_read, b_write, true), new(b_read, a_write, true)
Expand Down