Support elsif when stringifying If nodes#15918
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jun 25, 2025
Merged
Support elsif when stringifying If nodes#15918straight-shoota merged 2 commits intocrystal-lang:masterfrom
elsif when stringifying If nodes#15918straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Jun 23, 2025
Member
|
I'm not sure if this is okay... IMO stringification should print a representation of the AST node, not implicitly transform it. If we want such a transformation, perhaps it should better be explicit. |
Contributor
Author
|
There is no AST transformation per se, because there is simply no such thing as an |
straight-shoota
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
Ifnode's else-clause is itself a non-ternaryIfnode, combines the two nodes and emits anelsif, instead of anelseplus an indentedif. This is done even when the original nodes did not use anelsif, and applies to arbitrarily longIfchains.