Fix: thread specs must test Thread, not Fiber::ExecutionContext::Isolated#15909
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jun 18, 2025
Conversation
…ated The intent is to test Thread, and there's no need for an isolated context. This avoids a couple issues where we'd try to join the thread, but we should instead wait on the context.
ysbaddaden
added
kind:bug
straight-shoota
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to test
Threadand there's no need for an isolated context.Fixes a couple issues when running the std specs that I only just noticed. For example
pthread_mutex_destroyfailing with EBUSY, or an exception not being re-raised (of course, we join the thread, but the exception got captured by the isolated context). The failures might have been introduced by a5fe0ae and 3c74705.