Fix: race condition in Fiber::ExecutionContext::Isolated#wait#15872
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jun 6, 2025
Merged
Conversation
ysbaddaden
added
kind:bug
ysbaddaden
changed the title
Fiber::ExecutionContext::Isolated#wait
Collaborator
Author
|
The method should finally be correct. I ran into the race while testing #15871, where another thread can finish so fast that it races with the attempt to wait. With this patch, I can't reproduce the bug anymore. |
straight-shoota
approved these changes
Jun 3, 2025
straight-shoota
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't always enqueue the calling fiber in the wait list, to avoid a race condition, but always suspend it... which leads to the race condition never resuming the fiber 🤦