Fix duplicate keys in hash literals#15843
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom May 30, 2025
Merged
Fix duplicate keys in hash literals#15843straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
ysbaddaden
reviewed
May 28, 2025
spec/std/hash_spec.cr
Outdated
|
|
||
| it "works with mixed types" do | ||
| {1 => "a", "a" => 1, 2.0 => "a", "a" => 1.0}.values_at(1, "a", 2.0, "a").should eq({"a", 1, "a", 1.0}) | ||
| {1 => "a", "a" => 1, 2.0 => "a", "b" => 1.0}.values_at(1, "a", 2.0, "a").should eq({"a", 1, "a", 1.0}) |
Collaborator
There was a problem hiding this comment.
Thought: We're asking for the value of "a" twice, which happens to be 1 and equal to 1.0. Shall we ask for the value at "b" instead?
ysbaddaden
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered with ameba's
Lint/HashDuplicatedKeyrule.