Add BigRational#to_i#15809
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 26, 2025
Merged
Conversation
mverzilli
approved these changes
May 21, 2025
straight-shoota
approved these changes
May 22, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only type in the standard library where
#to_i32is already defined but#to_iisn't.This makes
BigRationalsuspectible to precision loss when passed tosprintf%i(see also #15808), sinceBigRational#to_i32currently delegates to#to_f64instead of#to_big_i. However this is still an improvement over the current situation whereBigRationalisn't supported bysprintfat all.