Optimize slice literal codegen on LLVM 21#15803
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom May 28, 2025
Merged
Optimize slice literal codegen on LLVM 21#15803straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
It's a bit confusing with all the reordering of code to figure out what was actually added.
Might I ask for two separate commits next time, one for the refactor, the other adding the new stuff? 🙇
I don't think it's worth it to resurrect llvm_ext. Let's just make sure to update our builds to use LLVM 21.
straight-shoota
approved these changes
May 20, 2025
Sija
reviewed
May 20, 2025
ysbaddaden
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2886 (comment).
Once again, this is something we could backport to earlier LLVM versions, but then LLVM 18 to 20 would remain unoptimized. Or do we re-enable
llvm_ext.ccfor those releases as well...?