Skip to content

Drop the static LLVM libraries on Windows MSVC CI#15797

Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom
HertzDevil:chore/windows-ci-llvm-static2
May 21, 2025
Merged

Drop the static LLVM libraries on Windows MSVC CI#15797
straight-shoota merged 4 commits intocrystal-lang:masterfrom
HertzDevil:chore/windows-ci-llvm-static2

Conversation

@HertzDevil
Copy link
Contributor

Supersedes #15074. This should now be completely doable after #15765.

@HertzDevil HertzDevil added platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci kind:chore labels May 19, 2025
@straight-shoota straight-shoota added this to the 1.17.0 milestone May 19, 2025
@HertzDevil
Copy link
Contributor Author

For convenience, LLVM_TARGETS now accepts commas, used to pass string arrays in PowerShell, and semicolons, used when building LLVM with CMake, as additional separators, on top of the whitespace, used by llvm-config.exe. It is highly unlikely any valid LLVM target name would contain a comma or semicolon.

@straight-shoota straight-shoota merged commit 900621a into crystal-lang:master May 21, 2025
42 checks passed
@HertzDevil HertzDevil deleted the chore/windows-ci-llvm-static2 branch May 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:chore platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure/ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants