Support debug info of 128-bit enum members#15770
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 15, 2025
Merged
Support debug info of 128-bit enum members#15770straight-shoota merged 1 commit intocrystal-lang:masterfrom
straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the LLVM 21 development branch, the
LLVMDIBuilderCreateEnumeratorOfArbitraryPrecisionfunction (which I submitted to LLVM) supports enumerators larger than the 64 bits thatLLVMDIBuilderCreateEnumeratorcan handle.The underlying C++ implementation can be backported all the way back to LLVM 13, but if we added it to
llvm_ext.cc, this would create an awkward situation where version 18 to 20 would miss out for no apparent reason. Thus this PR requires LLVM 21 or above.