Remove type binding on T for Pointer(T)#value=#15751
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 8, 2025
Merged
Remove type binding on T for Pointer(T)#value=#15751straight-shoota merged 1 commit intocrystal-lang:masterfrom
T for Pointer(T)#value=#15751straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:bug
Collaborator
|
Is it even possible to infer the pointer element type? 🤔 We can either |
ysbaddaden
approved these changes
May 6, 2025
Collaborator
|
Successfully created backport PR for |
straight-shoota
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15742. Does not fix the first snippet of #15742 (comment) (this is a different bug that also occurs on compilers before 1.16).
Only the type of a whole assignment (
ptr.value = x) needs to be bound to the right-hand side's type. The element type ofptrshall be inferred from the assignments toptritself, and I don't think it makes sense to do this from the individual#value=calls.