Add Crystal::System.wstr_literal on Windows#15747
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom May 26, 2025
Merged
Add Crystal::System.wstr_literal on Windows#15747straight-shoota merged 4 commits intocrystal-lang:masterfrom
Crystal::System.wstr_literal on Windows#15747straight-shoota merged 4 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
kind:refactor
platform:windows
ysbaddaden
reviewed
May 6, 2025
ysbaddaden
approved these changes
May 6, 2025
straight-shoota
approved these changes
May 22, 2025
ysbaddaden
approved these changes
May 22, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
StringLiteral#to_utf16was introduced in 1.13, we assume only 1.16 has complete support for slice literals (and this version number will most likely be bumped after #15746).