Skip to content

Fix Crystal::EventLoop::LibEvent and FiberExecutionContext integration#15743

Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom
ysbaddaden:fix/execution-context-evloop-libevent
May 8, 2025
Merged

Fix Crystal::EventLoop::LibEvent and FiberExecutionContext integration#15743
straight-shoota merged 1 commit intocrystal-lang:masterfrom
ysbaddaden:fix/execution-context-evloop-libevent

Conversation

@ysbaddaden
Copy link
Collaborator

Fixes a couple typos that break compilation when trying to use the libevent event loop and execution contexts.

@ysbaddaden ysbaddaden added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:runtime topic:multithreading labels May 5, 2025
@ysbaddaden ysbaddaden self-assigned this May 5, 2025
@ysbaddaden ysbaddaden changed the title Fix Crystal::EventLoop::LibEvent and FiberExecutionContext integration Fix Crystal::EventLoop::LibEvent and FiberExecutionContext integration May 5, 2025
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reminder that we need to add CI coverage for these flag combinations.

@straight-shoota straight-shoota added this to the 1.17.0 milestone May 6, 2025
@straight-shoota straight-shoota merged commit 6341b57 into crystal-lang:master May 8, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Multi-threading May 8, 2025
@crysbot
Copy link
Collaborator

crysbot commented May 9, 2025

@straight-shoota straight-shoota modified the milestones: 1.17.0, 1.16.3 May 9, 2025
straight-shoota pushed a commit that referenced this pull request May 10, 2025
…ation (#15743) (#15759)

Co-authored-by: Julien Portalier <julien@portalier.com>
@ysbaddaden ysbaddaden deleted the fix/execution-context-evloop-libevent branch May 10, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/1.16 kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:multithreading topic:stdlib:runtime

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants