Skip to content

Add extra Digest.update overloads for Bytes #15736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 2 commits into from
May 10, 2025
Merged

Add extra Digest.update overloads for Bytes #15736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f6e03d
Add `Digest.update` overloads for `Bytes`
straight-shoota Apr 30, 2025
a53d418
fixup
straight-shoota Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/digest/adler32.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ class Digest::Adler32 < ::Digest
end

def self.update(data, adler32 : UInt32) : UInt32
slice = data.to_slice
LibZ.adler32(adler32, slice, slice.size).to_u32
update data.to_slice, adler32
end

def self.update(data : Bytes, adler32 : UInt32) : UInt32
LibZ.adler32(adler32, data, data.size).to_u32
end

def self.combine(adler1 : UInt32, adler2 : UInt32, len) : UInt32
Expand Down
7 changes: 5 additions & 2 deletions src/digest/crc32.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ class Digest::CRC32 < ::Digest
end

def self.update(data, crc32 : UInt32) : UInt32
slice = data.to_slice
LibZ.crc32(crc32, slice, slice.size).to_u32
update data.to_slice, crc32
end

def self.update(data : Bytes, crc32 : UInt32) : UInt32
LibZ.crc32(crc32, data, data.size).to_u32
end

def self.combine(crc1 : UInt32, crc2 : UInt32, len) : UInt32
Expand Down