Skip to content

[Backport release/1.16] Fix run win32 console reader in bare thread #15726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Apr 28, 2025
Merged

[Backport release/1.16] Fix run win32 console reader in bare thread #15726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/crystal/system/win32/file_descriptor.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,11 +519,11 @@ private module ConsoleUtils
@@read_requests = Deque(ReadRequest).new
@@bytes_read = Deque(Int32).new
@@mtx = ::Thread::Mutex.new
{% if flag?(:execution_context) %}
@@reader_thread = ::Fiber::ExecutionContext::Isolated.new("READER-LOOP") { reader_loop }
{% else %}
@@reader_thread = ::Thread.new { reader_loop }
{% end %}

# Start a dedicated thread to block on reads from the console. Doesn't need an
# isolated execution context because there's no fiber communication (only
# thread communication) and only blocking I/O within the thread.
@@reader_thread = ::Thread.new { reader_loop }

private def self.reader_loop
while true
Expand Down