Skip to content

[Backport release/1.16] Do not add ReferenceStorage to Value's subclasses twice #15718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Apr 28, 2025
Merged

[Backport release/1.16] Do not add ReferenceStorage to Value's subclasses twice #15718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec/compiler/semantic/reference_storage_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,14 @@ describe "Semantic: ReferenceStorage" do
MyRef(Foo).new.u
CRYSTAL
end

it "adds ReferenceStorage to Value.subclasses once (#15677)" do
assert_type(<<-CRYSTAL) { bool }
@[Primitive(:ReferenceStorageType)]
struct ReferenceStorage(T) < Value
end

{{ Value.subclasses.select(&.<=(ReferenceStorage)).size == 1 ? true : nil }}
CRYSTAL
end
end
2 changes: 1 addition & 1 deletion src/compiler/crystal/semantic/top_level_visitor.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class Crystal::TopLevelVisitor < Crystal::SemanticVisitor
when node.splat_index
node.raise "BUG: Expected ReferenceStorageType to have no splat parameter"
end
type = GenericReferenceStorageType.new @program, scope, name, @program.value, type_vars
type = GenericReferenceStorageType.new @program, scope, name, @program.value, type_vars, false
type.declare_instance_var("@type_id", @program.int32)
type.can_be_stored = false
end
Expand Down