Fix run win32 console reader in thread instead of isolated context#15714
Closed
ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Closed
Fix run win32 console reader in thread instead of isolated context#15714ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
Also takes control over when the console is setup for UTF-8 and when we start the thread (in `kernel.cr` right before we start the stdios), instead of running at whatever time during the runtime startup.
ysbaddaden
added
kind:bug
ysbaddaden
changed the title
ysbaddaden
added
the
platform:windows
straight-shoota
changed the title
straight-shoota
approved these changes
Apr 28, 2025
Collaborator
Author
|
Sigh, Windows interpreter gets broken: https://github.com/crystal-lang/crystal/actions/runs/14703985934/job/41275681347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also takes control over when the console is setup for UTF-8 and when we start the thread (in
kernel.crright before we start the stdios), instead of running at whatever time during the runtime startup.Follow up to #15704