Handle properly stringifying multiline (boolean) expressions#15709
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 2, 2025
Merged
Conversation
Blacksmoke16
added
kind:feature
topic:lang:macros
topic:compiler:parser
and removed
topic:lang:macros
labels
Sija
reviewed
Apr 30, 2025
Comment on lines
+773
to
+774
| true || | ||
| false |
Contributor
There was a problem hiding this comment.
This should be indented the same as the regular code, I guess?
Suggested change
| true || | |
| false | |
| true || | |
| false |
ditto all below
Member
Author
There was a problem hiding this comment.
Dunno, formatter doesn't do anything with it in this macro context so imo it's fine as it is. The main objective was to have proper line numbers. Column numbers are less important. Esp when it's subjective what the indentation should be.
Member
There was a problem hiding this comment.
I suppose the formatter really should act on code inside macro expressions. Let's leave that for a follow-up, though.
Blacksmoke16
force-pushed
the
boolean-expression-string-representation
branch
from
29afd9b to
024a04d
Compare
straight-shoota
approved these changes
Apr 30, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously code like:
{% ( true || false ) %} {% ( 1 ) %}Would always be stringified as:
{% (true || false) %} {% (1) %}With this PR it now remains unchanged.
EDIT: Force pushed to rebase on master after #15614 was merged.