Fix: reopen async File passed to Process.exec and .run (win32)#15703
Merged
straight-shoota merged 5 commits intocrystal-lang:masterfrom Apr 29, 2025
Merged
Conversation
Sija
reviewed
Apr 24, 2025
Collaborator
Author
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Updated to use |
straight-shoota
approved these changes
Apr 24, 2025
9 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arguments for
input,outputanderrormust be handles withoutFILE_FLAG_OVERLAPPEDso we can't pass aFileopened withblocking: false... but we can reopen the filefrom itsusing#pathReOpenFileas blocking.This feels more like a hack than a proper solution. I initially triedReOpenFile, but I couldn't get it to work, while the crude hack just worked 🤷This is working as long as the file isn't closed, in which case we can just use the current file handle: we can pass an async closed handle (but can't reopen a closed file).
Extracted from #15685