Add type restrictions to Dir#15697
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Apr 30, 2025
Merged
Conversation
src/dir/glob.cr
Outdated
| record ConstantEntry, path : String, merged : Bool | ||
| record EntryMatch, pattern : String do | ||
| def matches?(string) : Bool | ||
| def matches?(string : String) : Bool |
Member
There was a problem hiding this comment.
suggestion: This entire type is an internal implementation detail. I don't think a type restriction matters here.
src/dir/glob.cr
Outdated
| record RootDirectory | ||
| record DirectoryMatch, pattern : String do | ||
| def matches?(string) : Bool | ||
| def matches?(string : String) : Bool |
straight-shoota
approved these changes
Apr 24, 2025
ysbaddaden
approved these changes
Apr 24, 2025
straight-shoota
changed the title
Dir
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the output of compiling cr-source-typer and running it with the below incantation:
This is related to #15682 .